fix: Properly catch not found explode cols #17020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
|
Can you add a test? |
Fixes pola-rs#15852. This adds a check for whether a column is defined or not in `explode`.
coastalwhite
force-pushed
the
fix-explode-column-panic-15852
branch
from
b57d0fd to
e168221
Compare
coastalwhite
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Already on it :) |
CodSpeed Performance ReportMerging #17020 will degrade performances by 17.06%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17020 +/- ##
==========================================
- Coverage 81.04% 81.00% -0.05%
==========================================
Files 1446 1448 +2
Lines 190422 190543 +121
Branches 2708 2722 +14
==========================================
+ Hits 154321 154340 +19
- Misses 35605 35700 +95
- Partials 496 503 +7 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jun 17, 2024
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15852.
This adds a check for whether a column is defined or not in
explode.